feat: support setting milestone for created issues #8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for setting milestones when creating GitHub issues. The implementation introduces a new Milestone enum that can handle both milestone IDs and titles, and adds milestone functionality to the issue creation workflow.
Key changes:
- Added a flexible
Milestoneenum supporting both ID and title-based milestone references - Extended the
Reportstruct to include an optional milestone field
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@amd-aliem https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#create-an-issue That's the API we're triggering on the GitHub side. You can see we're only adding the |
This allows us to hold state across GitHub requests without exposing that state as a command line option.
Workloaads likely know only the name of the milestone. On the other hand, the GitHub API knows only about the number of the milestone. Therefore, we load all milestones during launch so that we can automatically resolve the milestone number from the name.
|
I approved I just want to understand that one point I had above |
|
Tested w/ beacon passing --milestone "v3.0-0" - successfully opened an issue associated w/ that milestone in my fork: amd-aliem/sev-certify#17 Note that if a milestone is specified that is NOT found in the target repo, the issue is not created. |
|
@DGonzalezVillal I think you have to approve again because I resolved your comment. |
|
I approved, but I don't have write access |
3 participants
No description provided.